rust(feat): calculated channel MCP tools - #736
Merged
Merged
Conversation
evan-sift
changed the title
evan-sift
force-pushed
the
rust/mcp-calculated-channels
branch
from
August 26, 2026 07:55
707b4f1 to
6881374
Compare
evan-sift
marked this pull request as ready for review
August 26, 2026 08:21
lineville
reviewed
Aug 26, 2026
lineville
reviewed
Aug 26, 2026
lineville
reviewed
Aug 26, 2026
lineville
left a comment
lineville
left a comment
Contributor
There was a problem hiding this comment.
A couple small inconsistencies with the backend but other than that looks good!
… update, and archive
…user-notes-only updates
evan-sift
force-pushed
the
rust/mcp-calculated-channels
branch
from
August 27, 2026 04:40
b26c94e to
0bbb0e9
Compare
lineville
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
calculated_channelsdomain to the MCP server.Tool surface:
list_calculated_channels,list_calculated_channel_versions,create_calculated_channel,update_calculated_channel,archive_calculated_channel,unarchive_calculated_channel. Both list tools carry the crate'sfieldsprojection and reportcount/has_more.Nested channel references ride in
expression_channel_references_json, a documented JSON string parameter, keeping every other parameter flat. Update pre-reads the channel before writing: the update mask paths cover whole configuration messages, so a mask-only write would clear sibling fields the caller never mentioned.Surface note: there is no dedicated archive RPC. Archive and unarchive go through the update mask on
is_archived, matching the Python client, so the server owns the archive timestamp. They are exposed as separate tools so each can carry a destructive write gate, and the reported outcome is derived from the state the server returns rather than asserted.Stack note: the bundled agent skill and the 0.5.0 changelog for this whole stack land at the tip (#763).
Verification
cargo test -p sift_mcpon this branch: 332 passed, 0 failed (pagination, limit clamp, mask construction, archive/unarchive mask shape, state-mismatch reporting, write gates, JSON parameter validation, fields projection and count).cargo build -p sift_mcp --no-default-features,cargo fmt --all -- --check,cargo clippy -p sift_mcp --all-targets: clean.list_calculated_channelsround trip, and all four write tools reject with the remediation message when the server runs without--allow-create/--allow-destructive. The archive mechanism was since aligned with the Python client; its request shape is pinned by tests.